This repository has been archived by the owner on Jul 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Add Paper Doll HUD Mod #138
Open
DarkKronicle
wants to merge
2
commits into
Sol-Client:develop
Choose a base branch
from
DarkKronicle:feature/kronhud-elements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Paper Doll HUD Mod #138
DarkKronicle
wants to merge
2
commits into
Sol-Client:develop
from
DarkKronicle:feature/kronhud-elements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tysm! Please can you run |
TheKodeToad
suggested changes
Apr 25, 2023
// Originally from KronHUD | ||
// Added here by DarkKronicle :) | ||
// https://github.com/DarkKronicle/KronHUD/blob/master/src/main/java/io/github/darkkronicle/kronhud/gui/hud/PlayerHud.java | ||
@AbstractTranslationKey("sol_client.mod.paperdoll") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only meant for abstract classes
Comment on lines
+53
to
+64
protected List<ModOption<?>> createOptions() { | ||
List<ModOption<?>> options = super.createOptions(); | ||
Optional<String> format = Optional.empty(); | ||
options.add( | ||
new SliderOption( | ||
"sol_client.mod.paperdoll.option.rotation", | ||
ModOptionStorage.of(Number.class, () -> rotation, (value) -> rotation = value.floatValue()), | ||
format, 0, 360, 1 | ||
) | ||
); | ||
return options; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can already use the @Slider
annotation for this (no ping 4u)
Holy cow yessir thank you darkkronicle! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Before adding this into Sol, make sure to fix/implement this too DarkKronicle/KronHUD#125 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the paper doll mod from KronHUD. Very similar. One of my favorite mods. Has a cool dynamic rotation thing that lerps it to it's new rotation so you can actually see your player rotate.
(I realize this image has an elytra in it, this is just the image I found of KronHUD [it looks identical])