Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer-dependencies (styled-components, create-react-context) #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ESnark
Copy link

@ESnark ESnark commented Jul 13, 2024

Add dependencies required by styled-components(is-react) & crerate-react-context(prop-types)

@@ -130,9 +130,11 @@
"jw-paginate": "^1.0.4",
"lodash": "^4.17.21",
"polished": "^4.2.2",
"prop-types": "^15.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to run yarn install before commiting so that yarn.lock is updated too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I have to run that with yarn classic? I think it's time to move on. So I want to try Yarn 4 If ur ready.
There was no problem when I ran adminjs depending on the package of Yarn 4 + PnP.

@ESnark ESnark requested a review from dziraf July 31, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants