Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Access constraints' index #283

Merged

Conversation

EulalieCoevoet
Copy link
Member

No description provided.

Copy link
Member

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand, you now use a variable from BaseConstraintSet to store the id, instead of using a class-specific data member. It looks like it's the good thing to do, but I am surprised that this Data is not used at all in SOFA.

@EulalieCoevoet
Copy link
Member Author

I understand, but yes I think this index is only used by the constraints.
Most Lagrangian constraints in SOFA do not use this data, instead they redefine a local variable to store the constraint index. That's why I missed it when I implemented the plugin. But now, I was looking to make this index accessible for the user, and finally came across this data.

@alxbilger
Copy link
Member

Ok, in this case, should all constraints use the same base class Data? If yes, could you review that PR so it can be applied widely? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants