[constraint] adds JointConstraint #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update CI to build v23.06 branch. * Disable MacOS CI build for now.
* Fix install SofaPython3 CI action. Use non-nightly SofaPython3 builds for CI. * Allow macOS CI build but do not stop on deploy failure.
…ource Fix source code archives assets from release branch and not master.
EulalieCoevoet
changed the title
alxbilger
requested changes
Apr 15, 2024
|
Well if no one disagree I'll make the changes I proposed. |
- changes maxPositiveDisp/maxNegativeDisp to maxDisplacement/minDisplacement - removes references to angle - renames imposedValue to value - updates example wrt changes
EulalieCoevoet
changed the title
|
This is good for me. I'll merge it in two weeks, unless you need more time to look at it @TanguyNav @alxbilger ? |
alxbilger
approved these changes
Jun 4, 2024
alxbilger
reviewed
Jun 19, 2024
|
|
||
| def createScene(rootNode): | ||
| rootNode.addObject('RequiredPlugin', name='SoftRobots') | ||
| rootNode.addObject('RequiredPlugin', name='SoftRobots.Inverse') |
There was a problem hiding this comment.
@EulalieCoevoet Could you make sure that this plugin is not required? Thanks
There was a problem hiding this comment.
Oups sorry. Not needed indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @TanguyNav for this work!
Proposition of changes:
maxPositiveDisp/maxNegativeDisp, I would prefer usingmaxDisplacement/minDisplacement. When we want a positive minimum it's really weird to give a negative value. Even in the general case I find it confusing (I don't like it either in CableConstraint...).angle.valueandvalueTypein the other constraints (CableConstraint, SurfacePressureConstraint, PositionConstraint). I would prefer to keep it uniform and thus avoid usingimposedValueinstead ofvalue.