Render issues when running socket info
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love the attention that the CLI is getting now!! 🚀 |
bmeck
reviewed
Nov 13, 2023
lib/commands/info/index.js
Outdated
Comment on lines
204
to
215
| const uniqueIssues = issueDetails.reduce((/** @type {{ [key: string]: number }} */ acc, issue) => { | ||
| const { type } = issue | ||
| if (type) { | ||
| let count = 0 | ||
| if (!acc[type]) { | ||
| count += 1 | ||
| acc[type] = count | ||
| } else { | ||
| acc[type]++ | ||
| } | ||
| } | ||
| return acc |
There was a problem hiding this comment.
getting rid of count made it a bit easier for me to read at a glance, feel free to ignore this if you feel differently
Suggested change
| const uniqueIssues = issueDetails.reduce((/** @type {{ [key: string]: number }} */ acc, issue) => { | |
| const { type } = issue | |
| if (type) { | |
| let count = 0 | |
| if (!acc[type]) { | |
| count += 1 | |
| acc[type] = count | |
| } else { | |
| acc[type]++ | |
| } | |
| } | |
| return acc | |
| const uniqueIssues = issueDetails.reduce((/** @type {{ [key: string]: number }} */ acc, issue) => { | |
| const { type } = issue | |
| if (type) { | |
| if (!acc[type]) { | |
| acc[type] = 1 | |
| } else { | |
| acc[type]++ | |
| } | |
| } | |
| return acc |
bmeck
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
At the moment, when running
socket info, the number of critical and high severity issues is displayed but we're not showing what the issues actually are. This PR displays the issue types as well as the number of occurrences.I also thought it would make more sense to refactor the code so the info is displayed in the following order: