Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify code-base as ts and transpile to cjs for publish #153

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jdalton
Copy link
Collaborator

@jdalton jdalton commented Jul 24, 2024

  • Builds TS files
    • converting TS -> ESM
    • babel converting ESM -> CJS
    • rollup converting CJS -> ESM to bundle
    • rollup converting ESM -> CJS output
  • a dist folder is created with type .d.ts and d.ts.map files
  • package.json is updated with inlined external CJS deps added
  • tests run with tap (except one which failed under tap)

This comment was marked as outdated.

This comment was marked as outdated.

@socket-security-staging
Copy link

socket-security-staging bot commented Jul 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] environment, filesystem, unsafe Transitive: shell +52 11.3 MB nicolo-ribaudo
npm/@babel/[email protected] None +2 256 kB nicolo-ribaudo
npm/@babel/[email protected] None +2 191 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +36 6.8 MB nicolo-ribaudo
npm/@babel/[email protected] unsafe Transitive: environment, filesystem, shell +57 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem Transitive: shell, unsafe +151 17.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +43 7.77 MB nicolo-ribaudo
npm/@babel/[email protected] None +1 274 kB nicolo-ribaudo
npm/@cyclonedx/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +396 1.33 GB cyclonedx-automation
npm/@eslint/[email protected] None 0 47.7 kB eslintbot
npm/@inquirer/[email protected] Transitive: environment, filesystem, shell +34 816 kB sboudrias
npm/@rollup/[email protected] filesystem Transitive: environment, shell +25 3.45 MB shellscape
npm/@rollup/[email protected] filesystem Transitive: environment +11 389 kB shellscape
npm/@rollup/[email protected] None 0 26.4 kB shellscape
npm/@rollup/[email protected] None +3 223 kB shellscape
npm/@types/[email protected] None +1 2.16 MB types
npm/[email protected] environment, filesystem, network, shell +24 240 MB evanw
npm/[email protected] None 0 20.8 kB lydell
npm/[email protected] environment, filesystem, shell 0 4.01 kB typicode
npm/[email protected] None 0 12.7 kB npm-cli-ops
npm/[email protected] environment, eval Transitive: filesystem, shell, unsafe +36 5.22 MB webpro
npm/[email protected] None +1 565 kB antfu
npm/[email protected] environment, filesystem, unsafe 0 7.7 MB prettier-bot
npm/[email protected] Transitive: environment +30 1.49 MB sindresorhus
npm/[email protected] unsafe Transitive: environment, filesystem, shell +23 24.2 MB wessberg
npm/[email protected] environment, filesystem +18 44 MB lukastaegert
npm/[email protected] None 0 95.8 kB npm-cli-ops
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +134 43.3 MB isaacs
npm/[email protected] Transitive: environment, filesystem +13 1.13 MB plantain_00
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] environment +26 835 kB sindresorhus

🚮 Removed packages: npm/@cyclonedx/[email protected], npm/@inquirer/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security-staging
Copy link

socket-security-staging bot commented Jul 24, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@jdalton jdalton force-pushed the jdalton/unify branch 4 times, most recently from ac9b621 to b613636 Compare July 25, 2024 02:21
@jdalton

This comment was marked as outdated.

@jdalton jdalton force-pushed the jdalton/unify branch 4 times, most recently from c7872f5 to 6554f0f Compare July 25, 2024 17:57
@jdalton
Copy link
Collaborator Author

jdalton commented Jul 25, 2024

@SocketSecurity ignore npm/[email protected]

@jdalton jdalton force-pushed the jdalton/unify branch 8 times, most recently from dde173c to 48c4d30 Compare July 29, 2024 14:47
@jdalton jdalton force-pushed the jdalton/unify branch 4 times, most recently from 4adc214 to 3fde60e Compare August 12, 2024 15:12
@charliegerard charliegerard self-requested a review August 12, 2024 16:04
Copy link
Contributor

@charliegerard charliegerard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Just one thing I noticed is in the help menu, the command shows auditlog but it should be audit-log.

Screenshot 2024-08-12 at 9 08 29 AM

@jdalton
Copy link
Collaborator Author

jdalton commented Aug 13, 2024

LGTM! 🎉 Just one thing I noticed is in the help menu, the command shows auditlog but it should be audit-log.

Fixed!

@jdalton jdalton merged commit c9d92dd into master Aug 13, 2024
11 checks passed
@jdalton jdalton deleted the jdalton/unify branch August 13, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants