Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging module in newer versions of npm #119

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

charliegerard
Copy link
Contributor

@charliegerard charliegerard commented Jun 10, 2024

npm v10.6.0 + doesn't have the module npmlog as dependency anymore. Instead, it uses proc-log so I updated our wrapper to import the correct module based on the npm version used. Feels like a bit of a hack so let me know if you think of a better way.

@charliegerard charliegerard marked this pull request as ready for review June 10, 2024 16:32
@charliegerard charliegerard requested a review from bmeck June 10, 2024 16:33
Copy link
Collaborator

@bmeck bmeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@charliegerard charliegerard merged commit 8ce1b8c into master Jun 10, 2024
14 checks passed
@charliegerard charliegerard deleted the cg/fixNpmLogger branch June 10, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants