feat(api+admin): certification registry manager of a given certificat…

…ion can now delete a competence bloc
SocialGouv · Dec 6, 2024 · fc56590 · fc56590
1 parent a649bc9
commit fc56590
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/...ificationId]/bloc-competence/[certificationCompetenceBlocId]/updateCompetenceBloc.hook.ts b/...ificationId]/bloc-competence/[certificationCompetenceBlocId]/updateCompetenceBloc.hook.ts
@@ -39,9 +39,11 @@ const updateCertificationCompetenceBlocMutation = graphql(`
 
 const deleteCertificationCompetenceBlocMutation = graphql(`
   mutation deleteCertificationCompetenceBlocForUpdateCompetenceBlocPage(
-    $certificationCompetenceBlocId: String!
+    $certificationId: ID!
+    $certificationCompetenceBlocId: ID!
   ) {
     referential_deleteCertificationCompetenceBloc(
+      certificationId: $certificationId
       certificationCompetenceBlocId: $certificationCompetenceBlocId
     ) {
       id
@@ -90,6 +92,7 @@ export const useUpdateCompetenceBlocPage = ({
   const deleteCertificationCompetenceBloc = useMutation({
     mutationFn: () =>
       graphqlClient.request(deleteCertificationCompetenceBlocMutation, {
+        certificationId: competenceBloc?.certification.id || "",
         certificationCompetenceBlocId,
       }),
   });

diff --git a/...ificationId]/bloc-competence/[certificationCompetenceBlocId]/updateCompetenceBloc.hook.ts b/...ificationId]/bloc-competence/[certificationCompetenceBlocId]/updateCompetenceBloc.hook.ts
@@ -39,9 +39,11 @@ const updateCertificationCompetenceBlocMutation = graphql(`
 
 const deleteCertificationCompetenceBlocMutation = graphql(`
   mutation deleteCertificationCompetenceBlocForCertificationRegistryManagerUpdateCompetenceBlocPage(
-    $certificationCompetenceBlocId: String!
+    $certificationId: ID!
+    $certificationCompetenceBlocId: ID!
   ) {
     referential_deleteCertificationCompetenceBloc(
+      certificationId: $certificationId
       certificationCompetenceBlocId: $certificationCompetenceBlocId
     ) {
       id
@@ -90,6 +92,7 @@ export const useUpdateCompetenceBlocPage = ({
   const deleteCertificationCompetenceBloc = useMutation({
     mutationFn: () =>
       graphqlClient.request(deleteCertificationCompetenceBlocMutation, {
+        certificationId: competenceBloc?.certification.id || "",
         certificationCompetenceBlocId,
       }),
   });

diff --git a/packages/reva-api/modules/referential/referential.graphql b/packages/reva-api/modules/referential/referential.graphql
@@ -376,7 +376,8 @@ type Mutation {
     input: UpdateCompetenceBlocInput!
   ): CertificationCompetenceBloc
   referential_deleteCertificationCompetenceBloc(
-    certificationCompetenceBlocId: String!
+    certificationId: ID!
+    certificationCompetenceBlocId: ID!
   ): CertificationCompetenceBloc!
   referential_addCertification(input: AddCertificationInput!): Certification!
   referential_updateCertificationStructureAndCertificationAuthorities(

diff --git a/packages/reva-api/modules/referential/referential.security.ts b/packages/reva-api/modules/referential/referential.security.ts
@@ -25,9 +25,8 @@ export const referentialResolversSecurityMap = {
   "Mutation.referential_updateCertificationCompetenceBloc":
     isAdminOrCertificationRegistryManagerOfCertification,
   "Mutation.referential_addCertification": [hasRole(["admin"])],
-  "Mutation.referential_deleteCertificationCompetenceBloc": [
-    hasRole(["admin"]),
-  ],
+  "Mutation.referential_deleteCertificationCompetenceBloc":
+    isAdminOrCertificationRegistryManagerOfCertification,
   "Mutation.referential_updateCertificationStructureAndCertificationAuthorities":
     [hasRole(["admin"])],
   "Mutation.referential_sendCertificationToRegistryManager": [