feat(api): replaced the two certification activation/deactivation bat…

…ches by a single one
SocialGouv · Dec 13, 2024 · 27da3b2 · 27da3b2
1 parent 4998bc0
commit 27da3b2
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 30 deletions.
diff --git a/packages/reva-api/infra/cron.ts b/packages/reva-api/infra/cron.ts
@@ -12,8 +12,7 @@ import { batchPaymentRequestUnifvae } from "../modules/finance/unifvae/batches/p
 import { batchPaymentRequest } from "../modules/finance/unireva/batches/paymentRequest";
 import uploadSpoolerFiles from "../modules/finance/unireva/batches/paymentRequestProofJob";
 import { sendReminderToCandidateWithScheduledJury } from "../modules/jury/features/sendReminderToCandidateWithScheduledJury";
-import { deactivateCertificationsIfExpiresAtDateIsPast } from "../modules/referential/features/deactivateCertificationsIfExpiresAtDateIsPast";
-import { makeCertificationsAvailableIfAvailableAtDateIsPast } from "../modules/referential/features/makeCertificationsAvailableIfAvailableAtDateIsPast";
+import { setCertificationsVisibleOrNotUsingStatusAndAvailabilityDate } from "../modules/referential/features/setCertificationsVisibleOrNotUsingStatusAndAvailabilityDate";
 import { logger } from "../modules/shared/logger";
 import { prismaClient } from "../prisma/client";
 
@@ -110,8 +109,7 @@ CronJob.from({
       batchKey: "batch.activate-or-deactivate-certifications",
       batchCallback: async () => {
         logger.info("Running activate-or-deactivate-certifications batch");
-        await makeCertificationsAvailableIfAvailableAtDateIsPast();
-        await deactivateCertificationsIfExpiresAtDateIsPast();
+        await setCertificationsVisibleOrNotUsingStatusAndAvailabilityDate();
       },
     }),
   start: true,

diff --git a/...es/reva-api/modules/referential/features/deactivateCertificationsIfExpiresAtDateIsPast.ts b/...es/reva-api/modules/referential/features/deactivateCertificationsIfExpiresAtDateIsPast.ts
diff --git a/...va-api/modules/referential/features/makeCertificationsAvailableIfAvailableAtDateIsPast.ts b/...va-api/modules/referential/features/makeCertificationsAvailableIfAvailableAtDateIsPast.ts
diff --git a/...dules/referential/features/setCertificationsVisibleOrNotUsingStatusAndAvailabilityDate.ts b/...dules/referential/features/setCertificationsVisibleOrNotUsingStatusAndAvailabilityDate.ts
@@ -0,0 +1,16 @@
+import { startOfToday } from "date-fns";
+
+import { prismaClient } from "../../../prisma/client";
+
+export const setCertificationsVisibleOrNotUsingStatusAndAvailabilityDate = () =>
+  prismaClient.$transaction([
+    prismaClient.certification.updateMany({ data: { visible: false } }),
+    prismaClient.certification.updateMany({
+      where: {
+        status: "VALIDE_PAR_CERTIFICATEUR",
+        availableAt: { lte: startOfToday() },
+        expiresAt: { gt: startOfToday() },
+      },
+      data: { visible: true },
+    }),
+  ]);