feat: soft delete #642
Merged
feat: soft delete #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2022 14:35
…etch also data related to deletedAt
github-actions
bot
temporarily deployed
to
mano-feat-soft-delete-569crm
github-actions
bot
temporarily deployed
to
mano-feat-soft-delete-569crm
arnaudambro
force-pushed
the
feat--soft-delete
branch
from
6e94025 to
3eb0236
Compare
|
changé ! |
arnaudambro
commented
Apr 25, 2022
app/src/components/Loader.js
Outdated
| @@ -55,7 +55,7 @@ const mergeItems = (oldItems, newItems) => { | |||
|
|
|||
| const Loader = () => { | |||
| const [picture, setPicture] = useState([picture1, picture3, picture2][randomIntFromInterval(0, 2)]); | |||
| const [lastRefresh, setLastRefresh] = useStorage('last-refresh', 0); | |||
| const [lastRefresh, setLastRefresh] = useStorage('last-refresh--cache-version-2022-04-25', 0); | |||
There was a problem hiding this comment.
j'en ai profité aussi pour régler le problème de cache sans toucher à MMKV
github-actions
bot
temporarily deployed
to
mano-feat-soft-delete-569crm
rap2hpoutre
reviewed
Apr 25, 2022
arnaudambro
force-pushed
the
feat--soft-delete
branch
from
3eb0236 to
4c9efda
Compare
github-actions
bot
temporarily deployed
to
mano-feat-soft-delete-569crm
arnaudambro
force-pushed
the
feat--soft-delete
branch
from
4c9efda to
76ee90b
Compare
github-actions
bot
temporarily deployed
to
mano-feat-soft-delete-569crm
|
🎉 Deployment for commit d3c5122 : IngressesDocker images
Debug |
|
SonarCloud Quality Gate failed.
|
SocialGroovyBot
added a commit
that referenced
this pull request
Apr 26, 2022
# [1.95.0](v1.94.8...v1.95.0) (2022-04-26) ### Features * soft delete ([#642](#642)) ([2998209](2998209))
|
🎉 This PR is included in version 1.95.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Avec ce code qu'on envoie, on a toujours des éléments supprimés dans l'app qui ne devraient pas être là.
Solution simple et utile pour l'avenir: gérer les versions de cache (je pense ? qu'en penses-tu ?)
Je voulais faire une chose simple mais ça marchait pas, donc je ne l'ai pas encore fait
Je pense surtout qu'on aurait intérêt à changer de lib MMKV pour aller vers une plus populaire et plus simple d'utilisation, et potentiellement qui marche mieux: https://github.com/mrousavy/react-native-mmkv (voir: How is this library different from another mmkv?)