Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add config.yaml json schemas #411

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix: add config.yaml json schemas #411

merged 2 commits into from
Sep 1, 2023

Conversation

revolunet
Copy link
Member

@revolunet revolunet commented Sep 1, 2023 •
edited
Loading

initial schema for .kontinuous/config.yaml

The config.schema.json files are generated with provided script

@revolunet revolunet requested a review from devthejo September 1, 2023 00:09
devthejo
devthejo requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@devthejo devthejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should allow additional properties from the root (there are many more...)

@revolunet
Copy link
Member Author

I should remove all additionalProperties: true since "By default any additional properties are allowed." ?

https://json-schema.org/understanding-json-schema/reference/object.html#additional-properties

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@revolunet
Copy link
Member Author

good

@revolunet revolunet merged commit 9ebbe9b into master Sep 1, 2023
29 checks passed
@revolunet revolunet deleted the config-jsonschema branch September 1, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devthejo devthejo devthejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revolunet @devthejo