Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): utilisation de cdtn-utils au lieu de cdtn-source qui n'est plus d'actualité #1492

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

maxgfr
Copy link
Member

@maxgfr maxgfr commented Oct 15, 2024

Comment on lines 194 to 196
})),
source: SOURCES.SHEET_MT_PAGE,
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Avant il n'y avait pas de types, j'en ai mis un car le typescript me pose soucis.... J'ai l'impression que c'est iso, mais bon chelou. Pourquoi n'avions nous pas de types avant ???

Copy link

Copy link

🎉 Deployment for commit 8909538 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-8909538bdbb149883cef5e1e45a9b13add3503b9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-8909538bdbb149883cef5e1e45a9b13add3503b9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-8909538bdbb149883cef5e1e45a9b13add3503b9
Debug

import { HasuraDocument } from "./common";

export type FicheTravailEmploi = HasuraDocument<
FicheTravailEmploiDoc,
"fiches_ministere_travail"
typeof SOURCES.SHEET_MT | typeof SOURCES.SHEET_MT_PAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne pense pas qu'il peut être des 2 types ici.

@maxgfr maxgfr merged commit 8858db4 into master Oct 16, 2024
25 checks passed
@maxgfr maxgfr deleted the maxgfr/modify-type2 branch October 16, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants