fix(alert): ne pas utiliser le base pour générer l'url des CCs #1469
Conversation
| throw new Error(`xlsx file url not valid : ${match[1]}`); | ||
| } | ||
| return `${baseMatch[1]}/${match[1]}`; | ||
| return `https://travail-emploi.gouv.fr/${match[1]}`; |
There was a problem hiding this comment.
Ils ont modifiés leur balise <base> sur leur site. Il n'y a plus le chevron fermant />.
Sur leur nouveau site, il n'y a plus la balise base.
Comme on connait l'adresse du site, autant la mettre en dur pour éviter ce genre de soucis.
m-maillot
force-pushed
the
fix/alerting
branch
from
b2ed678 to
9fa139f
Compare
m-maillot
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
| expect(result).toBe("https://www.domain.com/file1.xlsx"); | ||
| }); | ||
|
|
||
| it("should throw error if xlsx file is present but url is relative with base tag", async () => { |
There was a problem hiding this comment.
Ce cas n'existe plus car on ne se base plus sur la balise
|
🎉 Deployment for commit 9fa139f : Docker images
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| throw new Error(`xlsx file url not valid : ${match[1]}`); | ||
| } | ||
| return `${baseMatch[1]}/${match[1]}`; | ||
| return `https://travail-emploi.gouv.fr/${match[1]}`; |
No description provided.