-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fiches MT): utilisé le slug du document pour les fiches MT qui sont découpées en section pour de garder toujours le bon slug #1402
Conversation
…nt découpé en section afin de garder toujours le bon slug
const { cdtnId, title, id, isPublished, excludeFromSearch } = article; | ||
const slug = slugify(title); | ||
function splitArticle(article: any) { | ||
const { cdtnId, title, id, isPublished, excludeFromSearch, slug } = article; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
le fix est d'utilisé le slug du document et non de re-sluguifier le titre qui a pu changer
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
99581c3
to
ee50544
Compare
@@ -177,6 +177,7 @@ export async function cdtnDocumentsGen( | |||
SOURCES.SHEET_MT_PAGE, | |||
getBreadcrumbs | |||
); | |||
logger.info(`Fetched ${fichesMT.length} fiches travail`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ajoute juste un log pour voir ce qui prend du temps
Quality Gate failedFailed conditions |
🎉 Deployment for commit f5fc236 : Docker images
|
|
||
function splitArticle(article) { | ||
const { cdtnId, title, id, isPublished, excludeFromSearch } = article; | ||
const slug = slugify(title); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c'est top d'avoir enlevé ça pour l'edit mais lorsqu'on crée une nouvelle, ça ne va pas poser de soucis ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non je penses pas ce sont des split de pages MT existantes pas des edit/creation
Fix #5740