Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fiches MT): utilisé le slug du document pour les fiches MT qui sont découpées en section pour de garder toujours le bon slug #1402

Merged
merged 3 commits into from
May 28, 2024

Conversation

carolineBda
Copy link
Contributor

@carolineBda carolineBda commented May 23, 2024

Fix #5740

…nt découpé en section afin de garder toujours le bon slug
const { cdtnId, title, id, isPublished, excludeFromSearch } = article;
const slug = slugify(title);
function splitArticle(article: any) {
const { cdtnId, title, id, isPublished, excludeFromSearch, slug } = article;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le fix est d'utilisé le slug du document et non de re-sluguifier le titre qui a pu changer

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -177,6 +177,7 @@ export async function cdtnDocumentsGen(
SOURCES.SHEET_MT_PAGE,
getBreadcrumbs
);
logger.info(`Fetched ${fichesMT.length} fiches travail`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ajoute juste un log pour voir ce qui prend du temps

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Copy link

🎉 Deployment for commit f5fc236 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-f5fc23678dff269dfc08e1d371df55d499a00484
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-f5fc23678dff269dfc08e1d371df55d499a00484
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-f5fc23678dff269dfc08e1d371df55d499a00484
Debug


function splitArticle(article) {
const { cdtnId, title, id, isPublished, excludeFromSearch } = article;
const slug = slugify(title);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est top d'avoir enlevé ça pour l'edit mais lorsqu'on crée une nouvelle, ça ne va pas poser de soucis ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non je penses pas ce sont des split de pages MT existantes pas des edit/creation

@carolineBda carolineBda merged commit 9e2d2e8 into master May 28, 2024
28 of 29 checks passed
@carolineBda carolineBda deleted the linked-fix-slug branch May 28, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lien 404 dans les documents liés
4 participants