-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement message bloc no cdt #1394
feat: implement message bloc no cdt #1394
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
targets/export-elasticsearch/src/ingester/contributions/generateMessageBlock.ts
Outdated
Show resolved
Hide resolved
@@ -1,11 +1,17 @@ | |||
import { ContributionContentType } from "@socialgouv/cdtn-types"; | |||
import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il faudrait ajouter les de cas de tests qu'on vient d'ajouter dans cette PR
columns: | ||
- content_agreement | ||
- content_not_handled | ||
- content_agreement_without_legal | ||
- content_legal | ||
- content_not_handled | ||
- content_not_handled_without_legal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est dommage de faire ainsi.
On aurait pu avoir un seul content
qui est une column en string qui est en html et ensuite avoir un type
spécifique
Quality Gate passedIssues Measures |
🎉 Deployment for commit 6d2213b : IngressesDocker images
|
@@ -51,13 +51,16 @@ export async function generateContributions( | |||
|
|||
for (let i = 0; i < contributions.length; i++) { | |||
const contrib = contributions[i]; | |||
const contribGeneric = contributions.find( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top
No description provided.