-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modele): correction de la création des modèles #1393
Conversation
b10a886
to
d348a3d
Compare
Quality Gate passedIssues Measures |
🎉 Deployment for commit d348a3d : Docker images
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@@ -126,7 +126,7 @@ export class DocumentsService { | |||
): HasuraDocument<any> { | |||
return { | |||
cdtn_id: document?.cdtn_id ?? generateCdtnId(data.title), | |||
initial_id: data.id, | |||
initial_id: data.id!, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Du coup, on rajoute ça vu que ça peut être optionnel
@@ -6,7 +6,7 @@ import { | |||
import { fileSchema } from "../common/type"; | |||
|
|||
export const modelSchema = z.object({ | |||
id: z.string().uuid(), | |||
id: z.string().uuid().optional(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dans quel cas l'id n'est pas défini en fait ? Car sinon on peut modifier le type de base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il n'est pas présent dans le cas de la création. On peut modifier un autre type en effet, mais hier dans le feu de l'action j'ai été au plus simple.
fix: #1395