fix(contributions): rename otherAnswer field by contentType (#1027)

SocialGouv · Sep 26, 2023 · a590140 · a590140
1 parent e6cfbc0
commit a590140
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 14 deletions.
diff --git a/targets/frontend/src/components/contributions/answers/Answer.tsx b/targets/frontend/src/components/contributions/answers/Answer.tsx
@@ -54,7 +54,7 @@ export const ContributionsAnswer = ({
     values: answer,
     defaultValues: {
       content: "",
-      otherAnswer: "ANSWER",
+      contentType: "ANSWER",
       status: {
         status: "TODO",
       },
@@ -94,7 +94,7 @@ export const ContributionsAnswer = ({
       await updateAnswer({
         content: data.content,
         id: answer.id,
-        otherAnswer: data.otherAnswer,
+        contentType: data.contentType,
         status: newStatus,
         userId: user?.id,
         urlSp: data.urlSp,
@@ -184,13 +184,13 @@ export const ContributionsAnswer = ({
                   disabled={isNotEditable(answer)}
                   control={control}
                   rules={{
-                    required: answer && answer.otherAnswer === "ANSWER",
+                    required: answer && answer.contentType === "ANSWER",
                   }}
                 />
               </FormControl>
               {answer && (
                 <FormRadioGroup
-                  name="otherAnswer"
+                  name="contentType"
                   label="Type de réponse"
                   control={control}
                   disabled={isNotEditable(answer)}
@@ -213,7 +213,7 @@ export const ContributionsAnswer = ({
                     disabled={isNotEditable(answer)}
                     control={control}
                     rules={{
-                      required: answer && answer.otherAnswer === "SP",
+                      required: answer && answer.contentType === "SP",
                     }}
                   />
                 </FormControl>

diff --git a/targets/frontend/src/components/contributions/answers/answer.mutation.ts b/targets/frontend/src/components/contributions/answers/answer.mutation.ts
@@ -10,8 +10,8 @@ import {
 } from "./answerReferences";
 
 export const contributionAnswerUpdateMutation = `
-mutation contributionAnswerUpdate($id: uuid!, $content: String, $otherAnswer: String, $status: statustype!, $userId: uuid!, $urlSp: String, $kaliReferences: [contribution_answer_kali_references_insert_input!]!, $legiReferences: [contribution_answer_legi_references_insert_input!]!, $otherReferences: [contribution_answer_other_references_insert_input!]!, $cdtnReferences: [contribution_answer_cdtn_references_insert_input!]!) {
-  update_contribution_answers_by_pk(pk_columns: {id: $id}, _set: {content: $content, other_answer: $otherAnswer, url_sp: $urlSp}) {
+mutation contributionAnswerUpdate($id: uuid!, $content: String, $contentType: String, $status: statustype!, $userId: uuid!, $urlSp: String, $kaliReferences: [contribution_answer_kali_references_insert_input!]!, $legiReferences: [contribution_answer_legi_references_insert_input!]!, $otherReferences: [contribution_answer_other_references_insert_input!]!, $cdtnReferences: [contribution_answer_cdtn_references_insert_input!]!) {
+  update_contribution_answers_by_pk(pk_columns: {id: $id}, _set: {content: $content, content_type: $contentType, url_sp: $urlSp}) {
     __typename
   }
   insert_contribution_answer_statuses_one(object: {status: $status, user_id: $userId, answer_id: $id}) {
@@ -48,7 +48,7 @@ mutation contributionAnswerUpdate($id: uuid!, $content: String, $otherAnswer: St
 export type MutationProps = Pick<
   Answer,
   | "id"
-  | "otherAnswer"
+  | "contentType"
   | "urlSp"
   | "content"
   | "kaliReferences"

diff --git a/targets/frontend/src/components/contributions/answers/answer.query.ts b/targets/frontend/src/components/contributions/answers/answer.query.ts
@@ -12,7 +12,7 @@ query contribution_answer($id: uuid) {
     questionId: question_id
     agreementId: agreement_id
     content
-    otherAnswer: other_answer
+    contentType: content_type
     updatedAt: updated_at
     urlSp: url_sp
     question {

diff --git a/targets/frontend/src/components/contributions/questions/Question.query.ts b/targets/frontend/src/components/contributions/questions/Question.query.ts
@@ -18,7 +18,7 @@ query SelectQuestion($questionId: uuid) {
       order_by: {agreement_id: asc}
     ) {
       id
-      otherAnswer: other_answer
+      contentType: content_type
       agreement {
         id
         name

diff --git a/targets/frontend/src/components/contributions/type.ts b/targets/frontend/src/components/contributions/type.ts
@@ -91,13 +91,13 @@ export type CdtnReference = {
   document: Document;
 };
 
-export type OtherAnswer = "ANSWER" | "NOTHING" | "UNKNOWN" | "SP";
+export type ContentType = "ANSWER" | "NOTHING" | "UNKNOWN" | "SP";
 
 export type Answer = {
   id: string;
   agreementId: string;
   questionId: string;
-  otherAnswer?: OtherAnswer;
+  contentType?: ContentType;
   urlSp?: string;
   agreement: Agreement;
   statuses: AnswerStatus[];

diff --git a/targets/hasura/metadata/databases/default/tables/contribution_answers.yaml b/targets/hasura/metadata/databases/default/tables/contribution_answers.yaml
@@ -60,7 +60,7 @@ select_permissions:
         - agreement_id
         - content
         - id
-        - other_answer
+        - content_type
         - question_id
         - updated_at
         - url_sp
@@ -71,7 +71,7 @@ update_permissions:
     permission:
       columns:
         - content
-        - other_answer
+        - content_type
         - url_sp
       filter: {}
       check: null

diff --git a/...default/1695651246643_alter_table_contribution_answers_alter_column_other_answer/down.sql b/...default/1695651246643_alter_table_contribution_answers_alter_column_other_answer/down.sql
@@ -0,0 +1 @@
+alter table "contribution"."answers" rename column "content_type" to "other_answer";
diff --git a/...s/default/1695651246643_alter_table_contribution_answers_alter_column_other_answer/up.sql b/...s/default/1695651246643_alter_table_contribution_answers_alter_column_other_answer/up.sql
@@ -0,0 +1 @@
+alter table "contribution"."answers" rename column "other_answer" to "content_type";
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		alter table "contribution"."answers" rename column "content_type" to "other_answer";