Validate context length for generation and validation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jhilgart
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-nlimtiaco and
sfc-gh-dasilva
as code owners
| @@ -0,0 +1,11 @@ | |||
| _MODEL_CONTEXT_LENGTH = 7000 # We use 7k so that we can reserve 1k for response tokens. | |||
There was a problem hiding this comment.
Shouldn't we account for instruction tokens in the prompt?
There was a problem hiding this comment.
This is pretty loose as is. Instruction tokens, even for llama3, are only ~20 tokens.
I can add an additional buffer here though!
sfc-gh-dasilva
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.