Kschmaus port eval logic #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-kschmaus
requested review from
sfc-gh-rehuang,
sfc-gh-cnivera and
sfc-gh-jsummer
as code owners
sfc-gh-jsummer
requested changes
Dec 9, 2024
sfc-gh-tzayats
requested review from
sfc-gh-jsummer
and removed request for
sfc-gh-rehuang and
sfc-gh-cnivera
sfc-gh-jsummer
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[@sfc-gh-tzayats ]
Made necessary changes to merge into customer eval branch.
Any changes to other files come from
make fmt_lintthat was not run perviously. (wrong imports etc.)TODO: Make sure to load eval results from cache if they are present and clearly state this for customers.