Add DBT Semantic File Merging #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jsummer
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-dasilva,
sfc-gh-cnivera,
sfc-gh-yayin and
sfc-gh-kchang
as code owners
There was a problem hiding this comment.
Code LGTM - it looks like the linter is failing, mainly with missing type annotations. @sfc-gh-jsummer could you go through the errors and add the missing type hints?
The test run is here, for reference (also at the CI checks at the bottom of the PR): https://github.com/Snowflake-Labs/semantic-model-generator/actions/runs/10515125961/job/29134523988?pr=132
and you can run the formatter locally using make fmt_lint
|
|
||
| def upload_partner_semantic() -> bool: | ||
| """ | ||
| Upload the semantic model to a stage. |
There was a problem hiding this comment.
to clarify - this doesn't actually upload the file to a snowflake stage, right? just imports the contents locally?
sfc-gh-cnivera
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to upload DBT semantic file(s) to merge into generated semantic file for Cortex Analyst. User receives a dialog box to configure merge specifics and further refine in existing semantic file workflow.
Out of an abundance of caution, I have not rebased given the frequency of changes occurring in the repo.