Use union syntax for type hints
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-cnivera
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-dasilva,
sfc-gh-yayin and
sfc-gh-kchang
as code owners
sfc-gh-yayin
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had added a few type hints using
|(e.g.str | bool), but didn't realize this only works for Python >= 3.10. Users that were using 3.9 (which is allowed by our dependency manager) were running into errors when using the app because the | operand was not recognized.Changing the app to use
Unioninstead of|for compatibility.