Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My first commit #50

Merged
merged 6 commits into from
Jan 15, 2024
Merged

My first commit #50

merged 6 commits into from
Jan 15, 2024

Conversation

Garima-149
Copy link
Contributor

Display question numbers at each question and correct answer to user when answer selected is wrong @Nitya-Pasrija
Uploading Screenshot (6).png…

@Nitya-Pasrija
Copy link
Contributor

@Garima-149
Please tag the issue it solves

@Garima-149
Copy link
Contributor Author

Garima-149 commented Jan 5, 2024

Issue no. #20 @Nitya-Pasrija

@Akanchha112
Copy link
Contributor

Issue no. #20 @Nitya-Pasrija

Issue no. #20 @Nitya-Pasrija

Hello Garima! Congratulations on your first commit🎉! In this commit, we need to change some things like folder structure. Garima, there is already a js file for each thing in Dark And Light Folder, you don't need to create another js file as you have created game.js. You have to go through the code once and see what and where changes need to be made and change only that section. Moreover, I just cloned the changes and it is not working, the correct answer is not showing so make sure you add this functionality in the js file in the Dark and Light folders.

@Garima-149
Copy link
Contributor Author

Garima-149 commented Jan 6, 2024

Screenshot (6)
Screenshot (10) These 4 files include all the changes I made.
@Akanchha112 Actually,I didn't create a new js file .it already exits in code itself.Do I have to make changes in dark and light file separately?And please do tell ,Do i have to make a new commit after making changes ?

@Akanchha112
Copy link
Contributor

Screenshot (6) Screenshot (10) These 4 files include all the changes I made. @Akanchha112 Actually,I didn't create a new js file .it already exits in code itself.Do I have to make changes in dark and light file separately?And please do tell ,Do i have to make a new commit after making changes ?

Hey @Garima-149! I was mentioning this js file.
image
ANd yes you have make changes in both light and dark folder for any functionality. And yes you have to commit after making new changes.

@Garima-149
Copy link
Contributor Author

Garima-149 commented Jan 10, 2024

@Akanchha112 @Nitya-Pasrija
Screenshot (11)
I made commit to this pull request.Please check it.
Screenshot (12)

@Akanchha112 Akanchha112 merged commit 7758ccb into SnowScriptWinterOfCode:main Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants