Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive navbar #22

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

Akanksha-202
Copy link
Contributor

Copy link
Contributor

@Nitya-Pasrija Nitya-Pasrija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection! Advancing through the open source world!🎊🎊 :) Please be patient while our maintainers and reviewers check the code.

Copy link
Member

@ayushichoudhary-19 ayushichoudhary-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this extra padding at the bottom and align the design more closely with your initial proposal?

Current:
image

Expected:
image

@Akanksha-202
Copy link
Contributor Author

Sure sure, I'll make the changes asap

@Akanksha-202
Copy link
Contributor Author

image
Is it fine now? @ayushichoudhary-19

@ayushichoudhary-19 ayushichoudhary-19 merged commit 959ae5f into SnowScriptWinterOfCode:main Jan 2, 2024
1 check passed
@ayushichoudhary-19
Copy link
Member

Awesome work, @Akanksha-202 . This navbar is a great contribution to the project! 🥳

While it does cause some unintended changes in the education section (which will be addressed in another PR), please remember to git pull and synchronize with the latest repository changes before submitting future PRs to avoid unintended impacts on other sections.

Overall, your contribution is highly appreciated. Keep up the fantastic work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants