Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added certification section #20

Closed
wants to merge 0 commits into from

Conversation

namita0210
Copy link

  • Added certification section
  • Added buttons with certification links
  • added image to the certification section - to make it aesthetic
  • added certification section link to navbar
    The final look of the certification section is:
image

Also , the additional link to certification in the navbar looks like this
image

Please merge my PR :)

Copy link
Contributor

@Nitya-Pasrija Nitya-Pasrija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection! Advancing through the open source world!🎊🎊 :) Please be patient while our maintainers and reviewers check the code.

@Nitya-Pasrija
Copy link
Contributor

Why are there so many commits via one PR?

@namita0210
Copy link
Author

Why are there so many commits via one PR?

Hi,
Is there a max commit criteria?

( I am a ML developer - not well versed in web dev ( beginner), so I made commits at every step so that of there's a mistake I could go back to the previous step)

Sorry for the inconvenience, will keep a limited number of commits in the next PRs.

@ayushichoudhary-19
Copy link
Member

@namita0210, thank you for your work on the certification section! I noticed that the current color palette doesn't quite align with the overall design aesthetics of the website. Could you please modify the colors to ensure consistency?

Additionally, the design appears somewhat distinctive, resembling more of a banner. To fix this, I suggest increasing the height of the section and aligning the buttons – perhaps having two buttons in each row. This would improve the visual balance.

I look forward to seeing the updated design. If you have any questions or need further clarification, feel free to ask. Thanks!

@namita0210
Copy link
Author

@namita0210, thank you for your work on the certification section! I noticed that the current color palette doesn't quite align with the overall design aesthetics of the website. Could you please modify the colors to ensure consistency?

Additionally, the design appears somewhat distinctive, resembling more of a banner. To fix this, I suggest increasing the height of the section and aligning the buttons – perhaps having two buttons in each row. This would improve the visual balance.

I look forward to seeing the updated design. If you have any questions or need further clarification, feel free to ask. Thanks!

Sure @ayushichoudhary-19
Will make the changes as recommended in a short while. Thanks for the feedback.

@ayushichoudhary-19
Copy link
Member

Hey @namita0210, quick reminder!

Before committing any more changes, please take a moment to git pull the latest changes from the repository to ensure your work is in sync. This helps prevent any conflicts or merge issues down the line.

@namita0210
Copy link
Author

namita0210 commented Jan 2, 2024 via email

@ayushichoudhary-19
Copy link
Member

@namita0210, it appears that the requested changes haven't been made for quite some time, and in the interim, another contributor has timely created a certificate section through a different PR. Regrettably, we will need to close this Pull Request if the changes aren't made by midnight tonight.

We sincerely encourage you to make the necessary adjustments before the deadline!

Additionally, please be aware that your PR currently has merge conflicts. Ensure you run git pull to fetch the latest changes from the repository before updating your PR with new commits.

@namita0210
Copy link
Author

namita0210 commented Jan 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants