-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added certification section #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfection! Advancing through the open source world!🎊🎊 :) Please be patient while our maintainers and reviewers check the code.
Why are there so many commits via one PR? |
Hi, ( I am a ML developer - not well versed in web dev ( beginner), so I made commits at every step so that of there's a mistake I could go back to the previous step) Sorry for the inconvenience, will keep a limited number of commits in the next PRs. |
@namita0210, thank you for your work on the certification section! I noticed that the current color palette doesn't quite align with the overall design aesthetics of the website. Could you please modify the colors to ensure consistency? Additionally, the design appears somewhat distinctive, resembling more of a banner. To fix this, I suggest increasing the height of the section and aligning the buttons – perhaps having two buttons in each row. This would improve the visual balance. I look forward to seeing the updated design. If you have any questions or need further clarification, feel free to ask. Thanks! |
Sure @ayushichoudhary-19 |
Hey @namita0210, quick reminder! Before committing any more changes, please take a moment to |
Sure
…On Tue, 2 Jan, 2024, 2:54 pm Ayushi Choudhary, ***@***.***> wrote:
Hey @namita0210 <https://github.com/namita0210>, quick reminder!
Before committing any more changes, please take a moment to git pull the
latest changes from the repository to ensure your work is in sync. This
helps prevent any conflicts or merge issues down the line.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALDGUTY7C24FKRJBD4EXFU3YMPG6TAVCNFSM6AAAAABBGXEKUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTG44DAMZSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@namita0210, it appears that the requested changes haven't been made for quite some time, and in the interim, another contributor has timely created a certificate section through a different PR. Regrettably, we will need to close this Pull Request if the changes aren't made by midnight tonight. We sincerely encourage you to make the necessary adjustments before the deadline! Additionally, please be aware that your PR currently has merge conflicts. Ensure you run |
Yes, I am working on it.
…On Sat, 6 Jan, 2024, 12:30 pm Ayushi Choudhary, ***@***.***> wrote:
@namita0210 <https://github.com/namita0210>, it appears that the
requested changes haven't been made for quite some time, and in the
interim, another contributor has timely created a certificate section
through a different PR. Regrettably, we will need to close this Pull
Request if the changes aren't made by midnight tonight.
We sincerely encourage you to make the necessary adjustments before the
deadline!
Additionally, please be aware that your PR currently has merge conflicts.
Ensure you run git pull to fetch the latest changes from the repository
before updating your PR with new commits.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALDGUTZPVSXAEG3VJW2BF6LYNDZBDAVCNFSM6AAAAABBGXEKUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGU3TMOJZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The final look of the certification section is:
Also , the additional link to certification in the navbar looks like this
Please merge my PR :)