Refactored some types to avoid "as" casting #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikalai-snap
force-pushed
the
ms/fix-provides-class
branch
from
246be8f to
3b333d1
Compare
kburov-sc
reviewed
Nov 28, 2024
src/Container.ts
Outdated
| providesClass = < | ||
| Token extends TokenType, | ||
| Tokens extends readonly ValidTokens<Services>[], | ||
| Class extends { |
There was a problem hiding this comment.
Nice, does it mean we can remove InjectableClass and ClassInjectable now?
There was a problem hiding this comment.
yes, removed that.
|
Don't forget to bump version up |
mikalai-snap
force-pushed
the
ms/fix-provides-class
branch
from
023ac7f to
eeaa7dd
Compare
# Conflicts: # src/Container.ts
mikalai-snap
force-pushed
the
ms/fix-provides-class
branch
from
b1c4404 to
6ac71b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "as" casting bothered me when we started to explicitly specify return types of
provide*/append*methods and I decided to dig into whyprovidesServicedoesn't return a type that we expect. This PR is the result of this. No broken unit tests, so the expectations remain the same.I want to do similar cleanup to PartialContainer, but that might be don in another PR.