Async flash #781
Open
Async flash #781
+1,024
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-percent is a mutable config (#236)
…rints, removed unwanted reset of pointers
* Overload CPU reading metric * fix * fix
update insufficient replicas metrics to separate severity
* update overload-ignore-list to be use subnets as well * get ip directly from conn * add getIPV4 impl * ntohl * don't shift at the end of the loop * update for more efficient impl and add ipv6 support * array of arrays * one combined array * have to reassign output of sdscat * include mask in operator< * replace raw numbers with constants * add log when we ignore client for loadshedding
…243) * add overload-protect-tenacity to configure how many clients to evict * need to divide tenacity config by 100 to get percentage
* TLS cname loadshedding ignore list
|
Hi @JohnSully I have started testing this branch with fastsync enabled, up to your latest commit: Just a few observations, please ignore if there are irrelevant as I understand this branch is still work in progress: Transfer speed is very slowOn master, I see these in the logs: With RDB, the size is 4GB and completes pretty quick, so likely something is not quite configured correctly on my instance. Loading flagIs it possible to set the loading flag after the replica flushes the data? For RDB, when the loading flag is set, the replica will reject commands during loading so the client can handle this condition, without the loading flag the client will think the incomplete data is correct and handles this case differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.