Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake #421

Open
wants to merge 10,000 commits into
base: main_pre_flash
Choose a base branch
from
Open

CMake #421

wants to merge 10,000 commits into from

Conversation

SamuelMarks
Copy link

#3 was from over 3 years ago, so thought I'd restart the conversation.

Can probably contribute CMake support myself for y'all. Main advantages:

  • IDE integration;
  • CPack support (build packages for many platforms);
  • Cross-platform configuration & building (cmake), testing (ctest, cdash), packaging (cpack)

…and, along with vcpkg—or I suppose any package manager + pkg-config or what-have-you—one can:

  • Decouple dependencies from this repo (e.g., to test with different version combinations);
  • Support dependencies cross-platform

PS: I note your interest in supporting FreeBSD. That shouldn't be too difficult, particularly with this PR. Ditto for macOS. As for Windows, that'll be a more complex contribution… see my redis/redis#9728

@SamuelMarks
Copy link
Author

SamuelMarks commented Aug 22, 2023

Ouch:

This branch is 1 commit ahead, 14235 commits behind Snapchat:main

Merging latest, should be able to resolve issues next weekend

EDIT - Maybe you can change what HEAD this PR popints to, as it's now trying to merge 10,000 commits?!

…files ; [src/modules/CMakeLists.txt] Initial add for modules ; [CMakeLists.txt] Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.