Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is two commits
in [b5b9410] i
impl Sub for Size
, that just mirrors what theSubAssign
already does[ecb3f85] might be a little controvertial:
Sub
andSubAssign
operations onSize
are already saturating, but they saturate toi32::MIN
, which i don't personally think is very useful, because aSize
can (should) not be negative, which means that i always have to check before subtracting two sizes. i changed it so they saturate to0
.to saturate to 0, i added an assossiated
const ZERO: Self
to theCoordinate
trait.if you prefer, i could move them to a
Size::saturating_sub(other: Size)
instead, but i think that this change makesSize
more convenient to use.