Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SmartThings Energy to Aqara Light Switch H2 #1895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DongHoon-Ryu
Copy link
Contributor

  • Solve the problem that the timer callback function becomes nil.
  • Support powerConsumptionReport when energy management is at root endpoint(0).

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Fix assertion problem and support SmartThings Energy feature

Summary of Completed Tests

Check that the powerConsumptionReport is transmitted normally at every set timer interval (15 minutes).

 - Solve the problem that the timer callback function becomes nil.
 - Support powerConsumptionReport when energy management is at root endpoint(0).
Copy link

Copy link

Test Results

   64 files  ±0    406 suites  ±0   0s ⏱️ ±0s
2 013 tests ±0  2 006 ✅  - 7  0 💤 ±0  7 ❌ +7 
3 489 runs  ±0  3 482 ✅  - 7  0 💤 ±0  7 ❌ +7 

For more details on these failures, see this check.

Results for commit 3ce3d43. ± Comparison against base commit 7171fd3.

Copy link

File Coverage
All files 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 94%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3ce3d43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant