Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch #1497

InovelliUSA · 2024-07-03T21:28:17Z

No description provided.

CLAassistant · 2024-07-03T21:28:22Z

All committers have signed the CLA.

drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua

greens · 2024-08-14T18:32:22Z

drivers/SmartThings/zigbee-switch/profiles/inovelli-vzm31-sn.yml

+  - name: "parameter1"
+    title: "1. Dimming Speed (Remote)"
+    description: "This changes the speed that the light dims up when controlled from the hub. A setting of '0' turns the light immediately on. Increasing the value slows down the transition speed. Value is multiplied by 100ms. 
+  Default=25 (2500ms or 2.5s)"
+    required: false
+    preferenceType: number
+    definition:
+      minimum: 0
+      maximum: 126
+      default: 25
+  - name: "parameter2"
+    title: "2. Dimming Speed (Local)"
+    description: "This changes the speed that the light dims up when controlled at the switch. A setting of '0' turns the light immediately on. Increasing the value slows down the transition speed. Value is multiplied by 100ms. 
+  (i.e 25 = 2500ms or 2.5s) Default=127 (Sync with parameter 1)"
+    required: false
+    preferenceType: number
+    definition:
+      minimum: 0
+      maximum: 127
+      default: 127
+  - name: "parameter3"
+    title: "3. Ramp Rate (Remote)"
+    description: "This changes the speed that the light turns on when controlled from the hub. A setting of '0' turns the light immediately on. Increasing the value slows down the transition speed. Value is multiplied by 100ms. 
+  (i.e 25 = 2500ms or 2.5s) Default=127 (Sync with parameter 1)"
+    required: false
+    preferenceType: number
+    definition:
+      minimum: 0
+      maximum: 127
+      default: 127
+  - name: "parameter4"
+    title: "4. Ramp Rate (Local)"
+    description: "This changes the speed that the light turns on when controlled at the switch. A setting of '0' turns the light immediately on. Increasing the value slows down the transition speed. Value is multiplied by 100ms. 
+  (i.e 25 = 2500ms or 2.5s) Default=127 (Sync with parameter 3)"
+    required: false
+    preferenceType: number
+    definition:
+      minimum: 0
+      maximum: 127
+      default: 127


One suggestion I would make would just be to unify all 4 of these parameters into 1 that controls the transition speed in all scenarios.

We actually have 8 settings for this functionality so I have already consolidated it somewhat. I was told to try to use the same settings as what is in our red series driver that is already in the repo:

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/profiles/inovelli-dimmer-power-energy.yml

Line 48 in 2125c84

- name: "dimmingSpeed"

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/profiles/inovelli-dimmer-power-energy.yml

Line 98 in 2125c84

- name: "dimmingSpeedZWave"

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/profiles/inovelli-dimmer-power-energy.yml

Line 108 in 2125c84

- name: "rampRate"

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/profiles/inovelli-dimmer-power-energy.yml

Line 118 in 2125c84

- name: "rampRateZWave"

SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/profiles/inovelli-dimmer-power-energy.yml

Line 155 in 2125c84

- name: "autoOffTimer"

greens · 2024-08-14T18:32:47Z

drivers/SmartThings/zigbee-switch/profiles/inovelli-vzm31-sn.yml

+  - name: "parameter12"
+    title: "12. Auto Off Timer"
+    description: "Automatically turns the switch off after this many seconds. When the switch is turned on a timer is started. When the timer expires the switch turns off.
+  0=Auto Off Disabled."
+    required: false
+    preferenceType: number
+    definition:
+      minimum: 0
+      maximum: 32767
+      default: 0


We'd prefer if users used our rules and automations for this sort of behavior.

Sure no problem. I can remove it.

SmartThings routines

greens · 2024-09-10T00:12:49Z

drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua

+local function configuration_handler(driver, device, zb_rx)
+  for i,v in ipairs(zb_rx.body.zcl_body.attr_records) do
+    if (v.attr_id.value == 0x000D) then
+    elseif (v.attr_id.value == 0x0015) then
+    else
+    end
+  end
+end


this function doesn't seem to do anything

greens · 2024-09-10T00:13:24Z

drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua

+local version_handler = function(driver, device, value, zb_rx)
+end


nor this one. Is this intentional?

Just left over after stripping functionality from the driver. It was left on accident.

greens · 2024-09-10T00:15:07Z

drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua

+  else
+    -- "info_changed event duplicate detected. Not performing any actions."


I'd just remove this branch if you're not logging

greens · 2024-09-10T00:20:38Z

drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua

+            0xfc31,
+            0x01,
+            0x122f,


can you pull the cluster_id and mfg_code out and put them at the top of the file?

greens · 2024-09-10T00:22:39Z

drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua

+	  [clusters.SimpleMetering.ID] = {
+        [clusters.SimpleMetering.attributes.InstantaneousDemand.ID] = power_meter_handler,
+        [clusters.SimpleMetering.attributes.CurrentSummationDelivered.ID] = energy_meter_handler
+      },
+      [clusters.ElectricalMeasurement.ID] = {
+        [clusters.ElectricalMeasurement.attributes.ActivePower.ID] = power_meter_handler
+      }
+    },
+    global = {
+      [0xFC31] = {
+        [0x01] = configuration_handler
+      }
+    },
+    cluster = {
+      [0xFC31] = {
+        [0x00] = scene_handler,
+      }
+    }
+  },
+  capability_handlers = {
+    [capabilities.switch.ID] = {
+      [capabilities.switch.commands.on.NAME] = on_handler,
+      [capabilities.switch.commands.off.NAME] = off_handler,


nit: some mixed tabs and spaces here

greens · 2024-09-10T00:29:29Z

drivers/SmartThings/zigbee-switch/profiles/child-notification.yml

Could you rename this to match the other related profiles rgbw-bulb-[min_color_temp]-[max_color_temp].yml and add in the firmwareUpdate capability?

lelandblue · 2024-09-12T12:56:32Z

Hey @InovelliUSA Can you check out the open comment above on this PR please at your nearest opportunity? Thank you!

InovelliUSA · 2024-09-12T22:06:01Z

Hey @InovelliUSA Can you check out the open comment above on this PR please at your nearest opportunity? Thank you!

Sure, I will check it out right now.

InovelliUSA · 2024-09-12T23:20:08Z

I believe I have adjusted everything requested. I did find a bug that I addressed in info_changed as well. Other than that, I just changed what was asked.

8d4ab6a

github-actions · 2024-09-13T17:54:49Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2024-09-13T17:59:40Z

Test Results

64 files 406 suites 0s ⏱️
2 013 tests 2 013 ✅ 0 💤 0 ❌
3 489 runs 3 489 ✅ 0 💤 0 ❌

Results for commit 7c502a5.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-13T17:59:41Z

File	Coverage
All files	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/ge-link-bulb/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua	`37%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/multi-switch/init.lua	`87%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua	`94%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/init.lua	`73%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/vimar/init.lua	`70%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-dimmer-power-energy/enbrighten-metering-dimmer/init.lua	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/wallhero/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zigbee-switch-power/aurora-relay/init.lua	`80%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/jasco/init.lua	`94%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7c502a5

greens · 2024-09-13T18:09:45Z

drivers/SmartThings/zigbee-switch/profiles/child-notification.yml

you need to git rm this file

K, I deleted it.

greens · 2024-09-13T18:10:29Z

Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning

    drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric

lelandblue · 2024-09-13T18:31:24Z

Hey @InovelliUSA Thanks so much.

We noticed that there arent yet Unit Tests written for this driver. We should have called this out a bit sooner, so apologies. I will recommend that we continue with the WWST process and we can review the driver tests in parallel. To learn more about unit driver tests, please see https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver

greens · 2024-09-13T22:34:47Z

Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning

    drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric

This still needs to be fixed in the meantime as well.

InovelliUSA · 2024-09-16T18:51:52Z

Checking drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua 1 warning

    drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua:62:9: (W211) unused variable numeric

This still needs to be fixed in the meantime as well.

This should be fixed now.

lelandblue · 2024-09-20T16:05:23Z

Hey @InovelliUSA Thanks so much.

We noticed that there arent yet Unit Tests written for this driver. We should have called this out a bit sooner, so apologies. I will recommend that we continue with the WWST process and we can review the driver tests in parallel. To learn more about unit driver tests, please see https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver

Hey @InovelliUSA - Can you let me know if you have any questions on the above message please? Thank you.

InovelliUSA · 2024-09-20T22:15:23Z

Hey @InovelliUSA Thanks so much.
We noticed that there arent yet Unit Tests written for this driver. We should have called this out a bit sooner, so apologies. I will recommend that we continue with the WWST process and we can review the driver tests in parallel. To learn more about unit driver tests, please see https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver

Hey @InovelliUSA - Can you let me know if you have any questions on the above message please? Thank you.

I have always tested with the device itself, so I haven't created the unit tests. I will have to research how to do that.

github-actions · 2024-09-23T12:58:07Z

Channel deleted.

lelandblue · 2024-10-28T17:42:14Z

@InovelliUSA Can you please review and sign the CLA? Thank you!

lelandblue · 2024-11-07T15:44:29Z

Hello - I am going to close this PR. If it needs to be reopened, it can be. Thank you.

github-actions · 2025-01-15T23:01:59Z

Channel deleted.

lelandblue · 2025-01-22T16:20:59Z

Hello @InovelliUSA We can merge this PR and deploy, however we need a signature on the CLA. Can you please review at your nearest opportunity?

Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.

InovelliUSA · 2025-01-22T20:16:23Z

Hello @InovelliUSA We can merge this PR and deploy, however we need a signature on the CLA. Can you please review at your nearest opportunity?

Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.

Sorry about that, I think I just completed it.

lelandblue · 2025-01-23T19:05:19Z

It appears that @erocm123 needs to still sign, are they available to sign the CLA?

erocm123 added 2 commits July 3, 2024 15:23

Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch

148912e

Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch

6e62fa7

Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch

ed5f9dc

cbaumler reviewed Jul 5, 2024

View reviewed changes

drivers/SmartThings/zigbee-switch/src/inovelli-vzm31-sn/init.lua Outdated Show resolved Hide resolved

erocm123 added 2 commits July 8, 2024 15:51

Changing copyright line

0a6ac32

Removing some parameters to simplify driver

0a2d07c

greens reviewed Aug 14, 2024

View reviewed changes

Removing auto off timer as per request. It is included as part of

5131907

SmartThings routines

greens reviewed Sep 10, 2024

View reviewed changes

Applying recommendations from ST from September 9 2024

8d4ab6a

greens reviewed Sep 13, 2024

View reviewed changes

Delete child-notification.yml

a90a605

Removing unused variable

8d2819b

Merge branch 'main' into main

b130f48

lelandblue requested a review from tpmanley October 28, 2024 17:17

greens approved these changes Oct 28, 2024

View reviewed changes

Merge branch 'main' into main

2973378

Merge branch 'main' into main

0f7f354

lelandblue added the do not merge label Nov 6, 2024

lelandblue closed this Nov 7, 2024

lelandblue reopened this Jan 15, 2025

Merge branch 'main' into main

030e6ad

Merge branch 'main' into main

436c927

Merge branch 'main' into main

7c502a5

lelandblue merged commit 72b357e into SmartThingsCommunity:main Jan 24, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch #1497

Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch #1497

InovelliUSA commented Jul 3, 2024

CLAassistant commented Jul 3, 2024 •

edited

Loading

greens Aug 14, 2024

InovelliUSA Aug 14, 2024

greens Aug 14, 2024

InovelliUSA Aug 14, 2024

greens Sep 10, 2024

greens Sep 10, 2024

InovelliUSA Sep 12, 2024

greens Sep 10, 2024

greens Sep 10, 2024

greens Sep 10, 2024

greens Sep 10, 2024

lelandblue commented Sep 12, 2024

InovelliUSA commented Sep 12, 2024

InovelliUSA commented Sep 12, 2024

github-actions bot commented Sep 13, 2024

github-actions bot commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

greens Sep 13, 2024

InovelliUSA Sep 13, 2024

greens commented Sep 13, 2024

lelandblue commented Sep 13, 2024

greens commented Sep 13, 2024

InovelliUSA commented Sep 16, 2024

lelandblue commented Sep 20, 2024

InovelliUSA commented Sep 20, 2024

github-actions bot commented Sep 23, 2024 •

edited

Loading

lelandblue commented Oct 28, 2024

lelandblue commented Nov 7, 2024

github-actions bot commented Jan 15, 2025 •

edited

Loading

lelandblue commented Jan 22, 2025

InovelliUSA commented Jan 22, 2025

lelandblue commented Jan 23, 2025

		local version_handler = function(driver, device, value, zb_rx)
		end

		else
		-- "info_changed event duplicate detected. Not performing any actions."

+xfc31,
+x01,
+x122f,

Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch #1497

Adding Support for Inovelli VZM31-SN Blue 2-1 Dimmer Switch #1497

Conversation

InovelliUSA commented Jul 3, 2024

CLAassistant commented Jul 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lelandblue commented Sep 12, 2024

InovelliUSA commented Sep 12, 2024

InovelliUSA commented Sep 12, 2024

github-actions bot commented Sep 13, 2024

github-actions bot commented Sep 13, 2024 • edited Loading

Test Results

github-actions bot commented Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greens commented Sep 13, 2024

lelandblue commented Sep 13, 2024

greens commented Sep 13, 2024

InovelliUSA commented Sep 16, 2024

lelandblue commented Sep 20, 2024

InovelliUSA commented Sep 20, 2024

github-actions bot commented Sep 23, 2024 • edited Loading

lelandblue commented Oct 28, 2024

lelandblue commented Nov 7, 2024

github-actions bot commented Jan 15, 2025 • edited Loading

lelandblue commented Jan 22, 2025

InovelliUSA commented Jan 22, 2025

lelandblue commented Jan 23, 2025

CLAassistant commented Jul 3, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading