Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 4,4,3 #1618

Merged
merged 29 commits into from
Feb 7, 2024
Merged

upgrade to 4,4,3 #1618

merged 29 commits into from
Feb 7, 2024

Conversation

jantje
Copy link
Member

@jantje jantje commented Jan 28, 2024

Still work in progress

@jantje
Copy link
Member Author

jantje commented Feb 1, 2024

@wimjongman
Hi Wim;
I'm trying to make a new release but I fail to get the products to load (no splash no icons)
I've been looking at this issue for some days now but still have no clue why the maven build starts without the splash
Would you be willing to take a look at this branch if you had some time?
Thanks
Jantje

@jantje
Copy link
Member Author

jantje commented Feb 1, 2024

@wimjongman
I think I found the issue.

@jantje
Copy link
Member Author

jantje commented Feb 1, 2024

@wimjongman
Here is what I found: eclipse-tycho/tycho#3433 (comment)
I'm thinking about when we talked about the fact I removed the application plugin.

@wimjongman
Copy link
Member

Great! Sorry for the late response, I am swamped with work.

@jantje
Copy link
Member Author

jantje commented Feb 2, 2024

@wimjongman
Don't be sorry. I'm grateful for your help.
In this case just calling in the cavalry was enough to win the battle.
Make sure you take enough "me time".

@jantje jantje merged commit e814cb2 into master Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants