Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Hardware Schema #151

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Updated Hardware Schema #151

wants to merge 8 commits into from

Conversation

Eirenliel
Copy link
Member

@ ShineBrightMeow I couldn't edit your branch, so I created this instead of #144

@Eirenliel Eirenliel mentioned this pull request Oct 30, 2024
Closed
@Eirenliel Eirenliel requested a review from ImUrX October 30, 2024 19:18
ImUrX
ImUrX requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@ImUrX ImUrX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you havent regenerated the schema, please run the .ps1

schema/datatypes/hardware_info.fbs Outdated Show resolved Hide resolved
lib/flatbuffers Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImUrX ImUrX ImUrX requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eirenliel @ImUrX @ShineBrightMeow