Dynamic Sfusion #363
Open
Dynamic Sfusion #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nocom/SlimeVR-Tracker-ESP into random-dev-branch-do-not-use
…nocom/SlimeVR-Tracker-ESP into random-dev-branch-do-not-use
Don't overclock official slimes Co-authored-by: Eiren Rain <[email protected]>
gorbit99
force-pushed
the
dynamic-sfusion
branch
from
d4cdeaf
to
4ff6e1b
Compare
l0ud
suggested changes
Nov 12, 2024
| float zroChangeOverTemperature = 0; | ||
|
|
||
| void handleTemperatureMeasurement(float temperature, float timeStep) { | ||
| #if USE_NONBLOCKING_CALIBRATION |
There was a problem hiding this comment.
No C define blocks in softfusion core please :<
Should be separated as different (replaceable) calibration implementation, or at least separated in less spaghetti way :<
| #include "../SensorFusionRestDetect.h" | ||
| #include "../nonblockingcalibration/NonBlockingCalibration.h" |
There was a problem hiding this comment.
This is subjective but I'm not the fan of "nonblocking" name for that. I think something like "auto" or "self-learning" is more descriptive for what it is.
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Not related strictly to the code, I would like to have some description (in PR I guess) about how that autocalibration works (both gyro and especially accel).
|
|
||
| // Temperature stability constant - how many degrees of temperature for the bias to | ||
| // change by 0.01 Though I don't know if it should be 0.1 or 0.01, this is a guess | ||
| // and seems to work better than 0.1 |
There was a problem hiding this comment.
It's neither 0.01 nor 0.1 for any sensor.
Eirenliel
requested changes
Nov 13, 2024
Co-authored-by: Eiren Rain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes: