Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webui): Merge Digit ROI and Analog ROI page to one page -> Number Sequences #172

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

Slider0007
Copy link
Owner

@Slider0007 Slider0007 commented Oct 11, 2024

Merge pages Settings > Regions Of Interest > Digit ROI and Settings > Regions Of Interest > Analog ROI to a single confiugration page Settings > Number Sequences. Within this page sequence numbers and all ROI types (digit and analog) are handled.

Benefits:

  • One location to handle all number sequence related tasks --> more streamlined and user friendly
  • All ROIs in one screen (Overlay configurable)
  • Reduced code size (No duplicate code for sequence handling needed)

image

image

@Slider0007 Slider0007 changed the title refactor(webui): Combine digit ROI and analog ROI page to one page --> Number Sequences refactor(webui): Merge Digit ROI and Analog ROI page to one page --> Number Sequences Oct 11, 2024
@Slider0007 Slider0007 changed the title refactor(webui): Merge Digit ROI and Analog ROI page to one page --> Number Sequences refactor(webui): Merge Digit ROI and Analog ROI page to one page -> Number Sequences Oct 11, 2024
@Slider0007 Slider0007 merged commit d4ff5c1 into develop Oct 14, 2024
8 checks passed
@Slider0007 Slider0007 deleted the webui-edit-sequence-3 branch October 14, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant