Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python-jose and add test cases #257

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Remove python-jose and add test cases #257

merged 1 commit into from
Jul 14, 2024

Conversation

Aisuko
Copy link
Contributor

@Aisuko Aisuko commented Jul 14, 2024 •
edited
Loading

Description

This PR fixes #254

(kirin-py3.11) root@1d3270884fb2:/workspaces/kirin# make test
test_jwt_decode (unit_tests.test_jwt.TestJWTReplacedSolution.test_jwt_decode) ... ok
test_jwt_jose (unit_tests.test_jwt.TestJWTReplacedSolution.test_jwt_jose) ... ok
test_http_post (unit_tests.test_method_kit.TestHTTPKits.test_http_post)
Test the http_post method. ... skipped 'Skip due to the fact that the server is not running'

----------------------------------------------------------------------
Ran 3 tests in 0.001s

OK (skipped=1)

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko marked this pull request as ready for review July 14, 2024 09:20
@Aisuko Aisuko requested review from Micost and jinronga July 14, 2024 09:21
@Aisuko Aisuko self-assigned this Jul 14, 2024
@Aisuko Aisuko added enhancement New feature or request apis test labels Jul 14, 2024
Micost
Micost approved these changes Jul 14, 2024
View reviewed changes
Copy link
Collaborator

@Micost Micost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aisuko Aisuko merged commit c7543c4 into main Jul 14, 2024
6 checks passed
@Aisuko Aisuko deleted the fix/securityjwt branch July 14, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micost Micost Micost approved these changes

@jinronga jinronga Awaiting requested review from jinronga

Assignees

@Aisuko Aisuko

Labels
apis enhancement New feature or request test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue]: remove python-jose
2 participants
@Aisuko @Micost