This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
model experimentation component #87
Open
wintonzheng
wants to merge
2
commits into
main
Choose a base branch
from
model_experimentation_component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
43 changes: 43 additions & 0 deletions
43
wyvern/components/models/model_experimentation_component.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# -*- coding: utf-8 -*- | ||
from typing import Dict, Optional | ||
|
||
from wyvern.components.models.model_component import BaseModelComponent | ||
from wyvern.entities.model_entities import MODEL_OUTPUT | ||
from wyvern.experimentation.client import experimentation_client | ||
from wyvern.wyvern_typing import INPUT_TYPE | ||
|
||
|
||
class ModelExperimentation(BaseModelComponent[INPUT_TYPE, MODEL_OUTPUT]): | ||
def __init__( | ||
self, | ||
# TODO: find a better name for assignment_mapping | ||
# this is the assignment var -> model mapping | ||
assignment_mapping: Dict[str, BaseModelComponent[INPUT_TYPE, MODEL_OUTPUT]], | ||
experiment_id: str, | ||
raise_error_on_none: bool = True, | ||
name: Optional[str] = None, | ||
): | ||
all_models = list(assignment_mapping.values()) | ||
super().__init__(*all_models, name=name) | ||
self.experiment_id = experiment_id | ||
self.assignment_mapping = assignment_mapping | ||
self.raise_error_on_none = raise_error_on_none | ||
|
||
async def execute(self, input: INPUT_TYPE, **kwargs) -> MODEL_OUTPUT: | ||
treatment = experimentation_client.get_experiment_result( | ||
self.experiment_id, | ||
self.get_entity_id(input), | ||
) | ||
# TODO: validation | ||
if treatment is None: | ||
# if self.raise_error_on_none: | ||
# raise ValueError("treatment is None") | ||
# else: | ||
# # use a default model? | ||
raise ValueError("treatment is None") | ||
|
||
model = self.assignment_mapping[treatment] | ||
return await model.execute(input, **kwargs) | ||
|
||
def get_entity_id(self, input: INPUT_TYPE) -> str: | ||
raise NotImplementedError |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: how shall we handle the
None
use case?