Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Commit

Permalink
return empty set for model component manifest_feature_names
Browse files Browse the repository at this point in the history
  • Loading branch information
wintonzheng committed Sep 15, 2023
1 parent 949f835 commit 14be425
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions wyvern/components/models/model_component.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,10 @@ def manifest_feature_names(self) -> Set[str]:
Our system will automatically fetch the required features from the feature store
to make this model evaluation possible
By default, a model component does not require any features, so this function returns an empty set
"""
raise NotImplementedError(
f"{self.__class__.__name__} is a ModelComponent. "
"The @cached_property function `manifest_feature_names` must be "
"implemented to define features required for the model.",
)
return set()

async def execute(self, input: MODEL_INPUT, **kwargs) -> MODEL_OUTPUT:
"""
Expand Down

0 comments on commit 14be425

Please sign in to comment.