-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(libgroup): implementation of login to account SocialLib #840
base: main
Are you sure you want to change the base?
Conversation
When would it be fixed? |
I'm spending the New Year holidays with my family and my laptop is not always at hand. I'm currently writing code to parse web pages for authorization, so maybe at 8-9 january, idk sorry. |
Btw thanks for the work |
Well... I can't make this function until aidoku-rs doesn't have a method to disable request redirect 💀 SocialLib in endpoint auth/login giving a response with a redirect on HTTP, and it seems breaks server side, because it redirects on first endpoint when it must redirect on page with hidden tokens in html code. Recent browsers use https protocol by default and don't notice http, they just replace http with https in URL when aidoku-rs redirects directly. |
Well, it turns out we have to wait until the Aidoku developer fixes this bug. And as I understand it, it can take a long time. |
that's not bug |
but what is needed to solve this problem? |
I wouldn't even think of adding ability of disabling redirect, if I didn't know about this case. That's why it's not a bug |
I see, so we'll have to wait until the method to disable request redirect appears? And it's just a matter of time until they add this feature? |
Yes. We have to wait until the method is added to the API, but as far as I know, a new Aidoku API (0.7) will appear soon, which will have this method, and I have rewrite source for the API. Ну да по сути надо ждать пока не появится метод в API, но вроде бы скоро будет совершенно новый API, где это можно будет сделать, поэтому мне придется переписывать расширение, оно работать-то будет, но просто будет с пометкой легаси, пока не перепишу под новый. Кстати, о языке, здесь я буду исключительно на английском коммуницировать чисто из правила хорошего тона, это соообщение — исключение. |
Got it, all that's left is to wait for the new version of the app to come out. Thanks for the info, I'm looking forward to you fixing this. |
This feature gives access to NSFW libgroup sites and access to manga chapters tagged 18+, which are not available without an account (closes #805)
Checklist:
nsfw
valueid
even if a source's name or language were changed