Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libgroup): implementation of login to account SocialLib #840

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vlapskii
Copy link
Contributor

@vlapskii vlapskii commented Jan 3, 2025

This feature gives access to NSFW libgroup sites and access to manga chapters tagged 18+, which are not available without an account (closes #805)

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

@vlapskii vlapskii changed the title feature(libgroup): implementation of login to account SocialLib feat(libgroup): implementation of login to account SocialLib Jan 3, 2025
@maksim-katafalk
Copy link

When would it be fixed?

@vlapskii
Copy link
Contributor Author

vlapskii commented Jan 4, 2025

I'm spending the New Year holidays with my family and my laptop is not always at hand. I'm currently writing code to parse web pages for authorization, so maybe at 8-9 january, idk sorry.

@maksim-katafalk
Copy link

Btw thanks for the work

@vlapskii
Copy link
Contributor Author

vlapskii commented Jan 5, 2025

Well... I can't make this function until aidoku-rs doesn't have a method to disable request redirect 💀

SocialLib in endpoint auth/login giving a response with a redirect on HTTP, and it seems breaks server side, because it redirects on first endpoint when it must redirect on page with hidden tokens in html code. Recent browsers use https protocol by default and don't notice http, they just replace http with https in URL when aidoku-rs redirects directly.

@maksim-katafalk
Copy link

Well, it turns out we have to wait until the Aidoku developer fixes this bug. And as I understand it, it can take a long time.

@vlapskii
Copy link
Contributor Author

vlapskii commented Jan 5, 2025

that's not bug

@maksim-katafalk
Copy link

but what is needed to solve this problem?

@vlapskii
Copy link
Contributor Author

vlapskii commented Jan 5, 2025

I wouldn't even think of adding ability of disabling redirect, if I didn't know about this case. That's why it's not a bug

@maksim-katafalk
Copy link

maksim-katafalk commented Jan 5, 2025

I see, so we'll have to wait until the method to disable request redirect appears? And it's just a matter of time until they add this feature?
Edit: че то я затупил и понял что необязательно на английском писать. Получается надо ждать пока разработчик изменит функцию перенаправления или че то в этом роде?

@vlapskii
Copy link
Contributor Author

vlapskii commented Jan 9, 2025

Yes. We have to wait until the method is added to the API, but as far as I know, a new Aidoku API (0.7) will appear soon, which will have this method, and I have rewrite source for the API.

Ну да по сути надо ждать пока не появится метод в API, но вроде бы скоро будет совершенно новый API, где это можно будет сделать, поэтому мне придется переписывать расширение, оно работать-то будет, но просто будет с пометкой легаси, пока не перепишу под новый. Кстати, о языке, здесь я буду исключительно на английском коммуницировать чисто из правила хорошего тона, это соообщение — исключение.

@maksim-katafalk
Copy link

Got it, all that's left is to wait for the new version of the app to come out. Thanks for the info, I'm looking forward to you fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mangalib missing chapters
2 participants