Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular][xmcloud] Init CloudSDK on browser #1952

Merged
merged 5 commits into from
Oct 22, 2024
Merged

[angular][xmcloud] Init CloudSDK on browser #1952

merged 5 commits into from
Oct 22, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Oct 16, 2024 •
edited
Loading

Description / Motivation

  • Initializes CloudSDK on browser for Angular app
  • Allows for other parts of app to use events etc

Note: adding events init TBD

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested review from illiakovalenko and a team October 16, 2024 23:01
yavorsk
yavorsk requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
See just one thing regarding the component description.
Also - does it make sense to rename the component or the selector for consistency - cloud-sdk-init vs app-cloudsdk-init?
And add changelog entry please :)

...tecore-jss/src/templates/angular-xmcloud/src/app/routing/scripts/cloud-sdk-init.component.ts Outdated Show resolved Hide resolved
@yavorsk
Copy link
Contributor

yavorsk commented Oct 21, 2024

Should we add the sitecore-cloudsdk dependencies to angular-xmcloud as well?

@art-alexeyenko
Copy link
Contributor Author

Should we add the sitecore-cloudsdk dependencies to angular-xmcloud as well?

true - it's now on angular side only

@yavorsk yavorsk merged commit 27e39a8 into dev Oct 22, 2024
1 check passed
@yavorsk yavorsk deleted the feature/jss-3529-angular-cloudsdk branch October 22, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

@illiakovalenko illiakovalenko Awaiting requested review from illiakovalenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @yavorsk