Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] XM Cloud Forms support #1951

Merged
merged 7 commits into from
Oct 22, 2024
Merged

[Angular] XM Cloud Forms support #1951

merged 7 commits into from
Oct 22, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 16, 2024

Description / Motivation

  • Introduced a new Form component:
    • The component is a wrapper around the built Sitecore Form that allows you to fetch and render the form from Sitecore Edge.
    • The component is a part of the @sitecore-jss/sitecore-jss-angular package.
    • Component is rendered only on the client side.
    • Handles the case when FormId is not provided, custom error message is displayed.
    • Handles the case when network error occurs during fetching the form from Sitecore Edge, custom error message is displayed.
  • Introduced a new InjectionToken EDGE_CONFIG to provide the configuration for the Form component to be able to fetch the form from Sitecore Edge.
  • Introduced a plugins technique for the component factory generation to add extensebility for add-ons.
  • Introduced a new "getEdgeProxyFormsUrl" method to get the URL for fetching the form from Sitecore Edge.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team October 16, 2024 18:36
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Please see only one comment.

@illiakovalenko illiakovalenko merged commit a0d83f1 into dev Oct 22, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-3539 branch October 22, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants