Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-angular] Fix style attribute from field not rendered properly in image field #1944

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[sitecore-jss-angular] Fix style attribute from field not rendered properly in image field #1944

merged 2 commits into from
Oct 8, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Oct 8, 2024

Description / Motivation

If image field has a style property, its value is an object and that's why it is not rendered properly. This PR addresses this issue

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - test in angular app with base site in editing mode in Pages. main image has a style attribute and it should be rendered properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team October 8, 2024 09:12
illiakovalenko
illiakovalenko approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko merged commit 785c996 into dev Oct 8, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-4305 branch October 8, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yavorsk @illiakovalenko