Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Upgrade to v17 #1939

Merged
merged 11 commits into from
Oct 7, 2024
Merged

[Angular] Upgrade to v17 #1939

merged 11 commits into from
Oct 7, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Oct 3, 2024 •
edited
Loading

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania changed the title [sitecore-jss-angular] Upgrade Angular to 17 [Angular] Upgrade to v17 Oct 3, 2024
@addy-pathania addy-pathania requested a review from a team October 3, 2024 19:06
art-alexeyenko
art-alexeyenko requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as always, Addy.
Added some small comments, and I have just one main concern here: how would we go about the upgrade guide? It won't be extensive, but we need to leave some pointers for people updating v21 apps.

packages/create-sitecore-jss/src/templates/angular/package.json Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/templates/angular/package.json Outdated Show resolved Hide resolved
packages/sitecore-jss-angular/package.json Outdated Show resolved Hide resolved
art-alexeyenko
art-alexeyenko requested changes Oct 4, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
illiakovalenko
illiakovalenko approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@addy-pathania addy-pathania merged commit 9454018 into release/21.0.0 Oct 7, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-3993-angular-17-upgrade branch October 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addy-pathania @art-alexeyenko @illiakovalenko @apathania22