Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-angular] Fix default empty field components to not render unwanted wrapping HTML tags #1937

Merged
merged 11 commits into from
Oct 2, 2024
Merged

[sitecore-jss-angular] Fix default empty field components to not render unwanted wrapping HTML tags #1937

merged 11 commits into from
Oct 2, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Oct 1, 2024 •
edited
Loading

Description / Motivation

The empty field scenarios for Link and Image breaks Pages editor because angular components returns extra wrapper tags. Pages Editor does not accept these wrapper tags therefore this fix removes those unwanted wrappers.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania changed the title [sitecore-jss-angular] Fix broken rendering of empty fields for Link and Image directives. [sitecore-jss-angular] Fix default empty field components to not render unwanted wrapping HTML tags Oct 1, 2024
@addy-pathania addy-pathania requested a review from a team October 1, 2024 19:43
yavorsk
yavorsk requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner than initial iterations - to keep everything in the default components. Some tests are failing and need to be updated - probably bc the tested element is not located properly after the changes

illiakovalenko
illiakovalenko approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appoved! However make sure to update the unit tests to make build green

CHANGELOG.md Show resolved Hide resolved
@addy-pathania addy-pathania merged commit 2794c8c into dev Oct 2, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-4268-empty-link-list branch October 2, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addy-pathania @yavorsk @illiakovalenko @apathania22