[sitecore-jss-nextjs]: Redirects with double and more parameters has been fixed for netlify #SXA-7554 #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 26, 2024 09:19
yavorsk
requested changes
Oct 3, 2024
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
…een moved Also the comments has been added
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-7554-redirects-double-parameters
branch
from
d750dd5 to
b7ec703
Compare
art-alexeyenko
pushed a commit
that referenced
this pull request
Oct 11, 2024
…been fixed for netlify #SXA-7554 (#1935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR includes a fix for an issue with Netlify, where URL parameters are being sorted by alphabet.
This causes redirects with two or more query parameters to not match the expected patterns.
To resolve this, a new method has been added that generates all possible permutations of the query parameters based on their arrangement. This ensures that the redirect logic can correctly handle unordered query strings, allowing for proper matching with URL patterns, regardless of how parameters are ordered in the incoming requests.
Testing Details
Types of changes