Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextjs] Update Cloudsdk to v0.4 #1933

Merged
merged 22 commits into from
Oct 31, 2024
Merged

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Sep 22, 2024

Description / Motivation

Updates cloudsdk dependencies to 0.4.0 and replaces the old init approach for cloudsdk with new one according to upgrade guide. This causes several followup changes.

  • [Breaking] Context logic is no longer used
  • New object type is passed into FEAAS.setContextProperties instead of context passed previously
  • @sitecore/components dependency updated to 2.0.0
  • Browser-side CloudSDK is initialized in Bootstrap component. It should be initialized for events to work.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - TBD when rc is published

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore

Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and please check the CI as yarn install is failing.

  1. Why do we still need to initialize the events? Cant we fire them directly after this upgrade?
  2. Did you check if we need to upgrade @sitecore/components, sitecore/byoc, @sitecore-feaas/clientside dependency and make any relevant changes?
  3. This would be a breaking change right?

Please update the upgrade guide and changelog.

@art-alexeyenko
Copy link
Contributor Author

art-alexeyenko commented Sep 24, 2024

@addy-pathania Good questions.

Why do we still need to initialize the events? Cant we fire them directly after this upgrade?

We cannot, initialization is still required.

Did you check if we need to upgrade @sitecore/components, sitecore/byoc, @sitecore-feaas/clientside dependency and make any relevant changes?

If we remove context logic - yes. I decided not to do that - not only @sitecore/components but FEAAS depends on it as well and it will require a good bit of refactoring. With seeming rush get the update done, I think the simpler appoach is best.

This would be a breaking change right?

Yeah you're right, since it will need an extra dependency. I'll put this in upgrade guide.

@art-alexeyenko art-alexeyenko changed the title [nextjs] Prepare cloudsdk update to v0.4 [nextjs] Update Cloudsdk to v0.4 Oct 28, 2024
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! see just one comment.
Also - don't we need to have upgrade entry for CDPPageView component?

Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@art-alexeyenko art-alexeyenko merged commit 0935408 into dev Oct 31, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the chore/jss-4058-update-cloudsdk branch October 31, 2024 18:16
art-alexeyenko added a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants