-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nextjs] Update Cloudsdk to v0.4 #1933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and please check the CI as yarn install
is failing.
- Why do we still need to initialize the events? Cant we fire them directly after this upgrade?
- Did you check if we need to upgrade @sitecore/components, sitecore/byoc, @sitecore-feaas/clientside dependency and make any relevant changes?
- This would be a breaking change right?
Please update the upgrade guide and changelog.
@addy-pathania Good questions.
We cannot, initialization is still required.
If we remove context logic - yes. I decided not to do that - not only @sitecore/components but FEAAS depends on it as well and it will require a good bit of refactoring. With seeming rush get the update done, I think the simpler appoach is best.
Yeah you're right, since it will need an extra dependency. I'll put this in upgrade guide. |
…4058-update-cloudsdk
…4058-update-cloudsdk # Conflicts: # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! see just one comment.
Also - don't we need to have upgrade entry for CDPPageView component?
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/components/CdpPageView.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/Bootstrap.tsx
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/byoc/index.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/Bootstrap.tsx
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/Bootstrap.tsx
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/Bootstrap.tsx
Outdated
Show resolved
Hide resolved
…4058-update-cloudsdk # Conflicts: # yarn.lock
Description / Motivation
Updates cloudsdk dependencies to 0.4.0 and replaces the old init approach for cloudsdk with new one according to upgrade guide. This causes several followup changes.
FEAAS.setContextProperties
instead of context passed previously@sitecore/components
dependency updated to 2.0.0Testing Details
Types of changes