Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-proxy][templates/node-xmcloud-proxy] Health check endpoint and middleware #1928

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Sep 12, 2024

Description / Motivation

Introduces health check middleware and endpoint for node-xmcloud-proxy.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team September 12, 2024 09:47
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
See last comment below and feel free to merge

@yavorsk yavorsk merged commit a69fed3 into dev Sep 12, 2024
1 check passed
@yavorsk yavorsk deleted the feature/jss-3557 branch September 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants