Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore][nextjs] Install sharp dependency for nextjs apps #1859

Merged
merged 2 commits into from
Jul 26, 2024
Merged

[Chore][nextjs] Install sharp dependency for nextjs apps #1859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
222b41a
have sharp installed
art-alexeyenko Jul 26, 2024
ac0519b
changelog, upgrade guide
art-alexeyenko Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Our versioning strategy is as follows:

* Update node/types to version 20 in all packages and samples ([#1810](https://github.com/Sitecore/jss/pull/1810))
* Github - Teams integration ([#1823](https://github.com/Sitecore/jss/pull/1823))
* [nextjs] Add `sharp` dependency to be in-line with nextjs's Image Optimizaion best practices: https://nextjs.org/docs/messages/install-sharp

## 22.0.0

Expand Down
3 changes: 3 additions & 0 deletions docs/upgrades/unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@
...
```

* It's highly recommended to install `sharp` dependency version `0.32.6` for nextjs apps in order to improve memory usage of Image Optimization feature. Run the `npm` command to install it:
`npm i [email protected]`

# nextjs-xmcloud

* Render a new `EditingScripts` component in your `Scripts.ts` file to support a new Editing Integration feature.
Expand Down
3 changes: 2 additions & 1 deletion packages/create-sitecore-jss/src/templates/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"next": "^14.1.0",
"next-localization": "^0.12.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react-dom": "^18.2.0",
"sharp": "0.32.6"
},
"devDependencies": {
"@graphql-codegen/cli": "^5.0.0",
Expand Down