Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create-sitecore-jss] Allow proxies to be initialized with main app and rework angular initializer #1858

Merged
merged 11 commits into from
Jul 29, 2024
Merged

[create-sitecore-jss] Allow proxies to be initialized with main app and rework angular initializer #1858

merged 11 commits into from
Jul 29, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jul 25, 2024 •
edited
Loading

Description / Motivation

  • Introduces new proxyAppDestination arg for create-sitecore-jss. It will be used as destination for node proxy apps, when present
  • Allows proxy apps to be installed alongside main apps (devex win!)
  • Adds some initial meat to angular-xmcloud and node-xmcloud-proxy templates, simplifying smoke testing

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team July 25, 2024 23:56
ambrauer
ambrauer suggested changes Jul 29, 2024
View reviewed changes
packages/create-sitecore-jss/src/bin.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/common/args/base.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/init-runner.ts Outdated Show resolved Hide resolved
packages/create-sitecore-jss/src/init-runner.ts Show resolved Hide resolved
packages/create-sitecore-jss/src/init-runner.ts Show resolved Hide resolved
@art-alexeyenko
Merge branch 'feature/angular-xmc-proxy' of https://github.com/Siteco…
df86981 
…re/jss into feature/jss-3563-proxy-rework

# Conflicts:
#	CHANGELOG.md
ambrauer
ambrauer approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@art-alexeyenko art-alexeyenko merged commit 084e16f into feature/angular-xmc-proxy Jul 29, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-3563-proxy-rework branch July 29, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

@addy-pathania addy-pathania Awaiting requested review from addy-pathania

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art-alexeyenko @ambrauer @addy-pathania