[templates/nextjs-xmcloud] Add xmcloud-specific comments in api/editing/render #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
reviewed
Jul 24, 2024
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/pages/api/editing/render.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
Jul 24, 2024
ambrauer
reviewed
Jul 24, 2024
packages/create-sitecore-jss/src/templates/nextjs-xmcloud/src/pages/api/editing/render.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Updates the comment in api/editing/render endpoint for XMCloud apps with description of new Metadata editing mode flow.
create-sitecore-jss helper cannot determine the addons being installed, so the comment was added as part of an override file in nextjs-xmcloud.
Testing Details
Types of changes