Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js] Image optimization remote pattern for XM Cloud CM/preview images #1850

Merged
merged 2 commits into from
Jul 24, 2024
Merged

[Next.js] Image optimization remote pattern for XM Cloud CM/preview images #1850

merged 2 commits into from
Jul 24, 2024

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Jul 24, 2024 •
edited
Loading

Description / Motivation

Follow-up to #1843. Added Next.js image optimization remote pattern for XM Cloud CM/preview images.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team July 24, 2024 15:05
addy-pathania
addy-pathania approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ambrauer ambrauer merged commit 14fba9f into dev Jul 24, 2024
1 check was pending
@ambrauer ambrauer deleted the bugfix/JSS-3646 branch July 24, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambrauer @addy-pathania